Babak K. Shandiz

Results 149 comments of Babak K. Shandiz

For what it's worth, the debug console works well with RTL texts. This is what I've tried: ![code](https://user-images.githubusercontent.com/36728931/51299921-49818e80-1a3f-11e9-8905-eda866eeebcb.png) And this is the output on the debug console: ![debug](https://user-images.githubusercontent.com/36728931/51299935-5b633180-1a3f-11e9-94d8-a7dabcf4d5d7.png) But the...

@Tyriar Sorry Tyriar, but it's still wrong. I commented under the pull request. https://github.com/xtermjs/xterm.js/pull/1899#issuecomment-455333377

@Tyriar I've just submitted the PR. You can check it anytime you want.

This may help: https://github.com/ExodiusStudios/vscode-comment-anchors/issues/8

@RyanCavanaugh I've submitted a PR for this issue. Would you please check it later?

@jcalz I think the issue you mentioned is solved by the PR. You can check it via [this](https://www.staging-typescript.org/play?ts=5.4.0-pr-56753-16) custom-build playground. As I checked the type inference is now showing `number...

@williammartin These are all valid JSONs: `999`, `true`, `false`, `null`, `"foo"`. So, I don't think it's really safe. Maybe moving the JSON unmarshal part to the end of the method...

I know it's not that pretty, but can't we just add a new argument, like `--json-field`, for such cases? This doesn't break CLI compatibility and also provides the desired improvements.

@williammartin I just pushed a PR for this. I also checked a few other `list` subcommands, and they also need a list of available JSON fields in their docs. If...