Adam Fuller
Adam Fuller
Had to increase Default Withdrawal Gas on DepositedERC721 for this to work with the origin contract on L2. Not sure what the ramifications of that might be, comments welcome.
I have added `onERC721Received` support to the gateway (cc @wighawag ), though I couldn't get the smocked Messenger to support it in the tests to check the message as in...
Fixed the smocked issue (with thanks to @smartcontracts see more [here](https://github.com/ethereum-optimism/smock/issues/38))
Is 256 blocks enough time, or does it create a very narrow window when it is possible to close allocations (the first 256 blocks of the epoch)? Also worried that...
Sure, I guess my thinking was as follows: - Close allocation needs to use the first block of the epoch (first block of a 24 hour period) - With this...
OK got it, that makes sense. Sorry I maybe landed in this PR without full context!
hey @dmelotik can you share the RPC call you are making to get the bottom result? And to clarify the comparison: blockNumber: 67915576 / 67915578 / 67915578
That makes sense to me - @Jannis what do you think? There is some corresponding work in `graph-node`, and maybe also in Gateways to support? Of course would also need...
Agree with @matthewlilley, often users will use BigInt simply for convenience / as a default, and users don't expect the native type
@dotansimha I think this is a reflection of the implementation in graph-node, I think you were looking into changing that?