Andrzej Zabost

Is sharedTest pattern still supported after Android Gradle Plugin 7.2.0?

11

Hi. I've just spotted this pattern on Robolectric's website: http://robolectric.org/blog/2021/10/06/sharedTest/ However, I recently stumbled upon the release notes for Android Gradle Plugin 7.2.0 ([link](https://developer.android.com/studio/releases/gradle-plugin#duplicate-content-roots)) which say: >Starting with AGP 7.2,...

Firebase and Google Maps API keys result in a wrong configuration

12

**Description** I think the plugin extracts wrong API keys (`google_api_key` and `google_crash_reporting_api_key`) from the google-services.json file during the Android app build in a certain scenario. Possibly, the issue is partially...

Neither aws-android-sdk-iot nor org.eclipse.paho.client.mqttv3 provide appropriate ProGuard/R8 rules

1

**Describe the bug** When `aws-android-sdk-iot` is used in an Android app with R8/ProGuard enabled, then the essential code gets removed and the library doesn't work properly. For example, I stumbled...

Plugin fails the build when Git executable is not available

1

### Describe the bug Bugsnag Android Gradle Plugin seems to **require** Git executable to be available and will fail otherwise, which is surprising and contradictory to the [documentation](https://docs.bugsnag.com/build-integrations/gradle/#additional-configuration) which literally...

The main purpose of this PR is to modularize this library so that the core feature, which is SLF4J binding, can be used without the burden of unnecessary dependencies such...

By default Kotlin makes every class and method `final` so it cannot be used without an explicit `open` modifier as the resulting `public final` modifier wouldn't be accepted as a...

Key's password should not have to be the same as the keystore's password

1

**Describe the bug** This SDK contains a few pieces of code that assume the key's password and the keystore's password are exactly the same. For example, both overloads of `AWSIotKeystoreHelper.getIotKeystore`...

Calling ensureActive instead of re-throwing CancellationException in suspendRunCatching

5

In `suspendRunCatching`, a `CancellationException` gets re-thrown: https://github.com/android/nowinandroid/blob/689ef92e41427ab70f82e2c9fe59755441deae92/core/data/src/main/kotlin/com/google/samples/apps/nowinandroid/core/data/SyncUtilities.kt#L58 However, according to this [post](https://betterprogramming.pub/the-silent-killer-thats-crashing-your-coroutines-9171d1e8f79b) (further acknowledged [here](https://github.com/Kotlin/kotlinx.coroutines/issues/3658#issuecomment-1465747377)), it's more advisable to `ensureActive()` instead. Maybe like this? ```kotlin private suspend fun suspendRunCatching(block: suspend...