Andy Young
Andy Young
NOTICE: Just a draft, need to work out the expected behavior with @sdispater as this new change defaults timezone to UTC when no timezone is provided (unlike locally before).
this is potentially breaking, but it is useful for how i'm using it at my company. do u think this is the correct behavior? it shouldnt be relying on the...
i believe this was fixed
@sdispater my opened pr has conflicts and it seems like you completely changed the code, could you confirm this has been fixed?
oh i was planning on finishing up the pr on this branch and merging it when it's ready, it's still kind of a draft
Also one of the build tools that checks for import cycles wasn't happy, I can take a look there really only is like 1% left to get this merged.
Basically the CI has a circular dependency check that isn't passing because it doesn't seem to like the import cycles that exist in React (which is normal). But yeah how...
Yeah the bigger issue is the link to the options page (from the listing page) doesn't work on Firefox for whatever reason... A fresh pair of eyes may help with...
@Step7750 Omg... This was the problem the whole time 😠https://github.com/csfloat/extension/blob/262a725729a9f55d6c2890d51da914b7f36e5126/src/lib/bridge/client.ts#L8
No, I totally missed that the content script background messaging isn't supported for firefox. @Step7750 any input on how you want this to be fixed?