Anders Musikka

Attributes should be reworked

2

Savefile uses a whole lot of attributes right now, all with the prefix 'savefile_' in their names. It would probably be better if instead the attribute was called 'savefile', and...

I think there may be a bug somewhere in how MassProperties 'add' operations are handled in rapier3d 0.8.0. See the following program: ```rust use rapier3d::na::{Point3, Isometry3, Vector3}; use rapier3d::dynamics::MassProperties; use...

Fix miscompile of implement_buffer_content-macro, other approach

3

This is an alternative approach to solving the problem https://github.com/glium/glium/issues/1949 . I think it's 100% free of UB and totally sound. But it only works on nightly rust.

Undefined behavior in implement_buffer_content!

2

The macro implement_buffer_content! contains the following code: ```rust #[inline] fn is_size_suitable(size: usize) -> bool { use std::mem; let fake_ptr: &$struct_name = unsafe { mem::transmute((0usize, 0usize)) }; let min_size = mem::size_of_val(fake_ptr);...

Savefile does not presently support recursive data-structures. To be precise, the problem is with the schema-function. The schema-function tries to provide a simple tree which describes the data format. However,...

Just a heads up to anyone thinking about trying this out: One of the prerequisites; rustc2duchain, doesn't build with recent versions of the rust nightly compiler. As far as I...

Add call to check total number of CPUs?

6

On linux, num_cpus::get() currently returns 1 if the calling thread has its sched_affinity set to only one thread. I have a use case where a main thread is pinned to...

Adapt crate to Stacked Borrows?

1

Hi, In your introduction you mention that it is impossible to determine if the unsafe things done in this crate are UB or not. Since the release of Stacked Borrows,...

Miri detects UB in test-suite

9

I tried running the arc-swap test bench under miri with the 'many seeds' feature active. ``` MIRIFLAGS=-Zmiri-many-seeds=0..2000 cargo miri test ``` It fails after a while, with the following error:...

## 🤖 New release * `savefile-derive`: 0.18.6 -> 0.18.7 * `savefile`: 0.18.6 -> 0.18.7 (✓ API compatible changes) * `savefile-abi`: 0.18.6 -> 0.18.7 (✓ API compatible changes) Changelog --- This...