Aviv Keller

Results 1031 comments of Aviv Keller

In my initial idea for #52509, I tried to move them, but I decided against it for a few reasons: 1) It's a semver major change (breaking) 2) They rely...

In my opinion, it is a misunderstood feature. When I saw the policy, I thought it was a way to stop 'trusted' code from accessing modules, which, in turn, ignores...

> My reports pushed you to make this thinking and this decision, but my reports are invalid as ā€œinformativeā€. That’s how you treat the researcher spent time on your experimental...

Whether it's 'fair' or not shouldn't be the end goal. As a security researcher who also worked on this feature, I think the whole 'fair' / 'not fair' mentally isn't...

While it's great that we are all in a better mindset, I don't believe a public Github issue is the best place to discuss *specific* security concerns. Keep in mind,...

Thanks for your work with the community! It's so amazing that people volunteer to do this amazing work!

When I get a change, Ill adjust the small prettification differences

I know Deno supports it with its builtin standard library (https://deno.land/[email protected]/jsonc), but I'm not sure about importing I'll need to check the other runtimes, and more about Denos imports

I'm a fan of this idea, but IMO the file names could drop the `event_emitter_` prefix, but that's only my opinion.

> We should also be careful about the impact. We don't want everyone to suddenly have 500 new notifications. Yes, that is a lot off issues :-/, WDYT should be...