Avik Chaudhuri
Avik Chaudhuri
I don't see anything on nested `GraphModule`s, is that intentional or are they considered part of `parameters`? For `cond` I encountered nested true/false functions that compile to nested submodules and...
A few questions / comments: 1. How does this relate to #96012? Does it subsume it? 2. I see a bunch of `dynamic_dims_range` fields. IMO these should be `dynamic_dims_constraints`. It's...
Do we really want `clear_dynamic_dims` and `has_dynamic_dims` as part of the public API? Looks like we need docs for those if so, but it feels like they shouldn't be exposed...
> @suo we are in an unfortunate place where we have a fairly complicated piece of symbolic reasoning code but it is _only_ used by export, so I'm not even...
> Regarding the constraint solver, could you guys add me if there is any call discussing that? Thank you! Sent an invite, hope the time works!
Here's some reading material on the existing implementation of the dynamic shapes front-end and the constraint solver for export: https://docs.google.com/document/d/1SpaqdBjWNckJGZj0m3aRSdLMt5fdENp0i6XS_y229og/edit
@ezyang @lezcano this is ready for another review. Thanks!
This is on our short-term todo list. See http://flowtype.org/docs/coming-soon.html#_
What's the desired behavior here? If we were to mimic what happens with dynamic shapes, either * we need to make an assertion that the input is 1, or *...