Piotr Grabowski

Results 88 comments of Piotr Grabowski

Just to update, the issue reduces to this: ```cpp struct counter_structure { int count; }; counter_structure* __attribute__ ((noinline)) make_counter_structure() { // Works fine without "__attribute__ ((noinline))" auto ptr = new...

> You can reduce it to this, really: > > ``` > int* make_int(); > void reproducer() { > auto p = make_int(); > if (*p == 0) { >...

> I wonder what's the logic behind it though, because the above triggers the warning and the below doesn't: Such modifications: - Replace `make_int()` with `new int` - Replace `if...

This warning seems to behave better if you use C `free()` instead of C++ `delete ptr`: ```cpp #include int* make_int(); void reproducer() { auto p = make_int(); // delete p;...

Submitted bug report here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105204

On that bug report, a GCC maintainer said that this is the expected behavior of that diagnostic. He suggested to use a workaround with `__builtin_unreachable()` allowing compiler to reason about...

@vladzcloudius At the time of making that patch, I tried getting your feedback (asking in comment: https://github.com/scylladb/scylla/issues/10440#issuecomment-1112111452; adding you as a reviewer: https://github.com/scylladb/scylla/pull/10456). What's your proposed alternative solution to #10440?

cc @tzach @annastuchlik @fruch

With Confluent 6.0.0 and the connector (configuration below), I can correctly insert the data. Console producer (first line is the command, second line is an input): ``` bin/kafka-avro-console-producer --broker-list 127.0.0.1:9092...

+1, however this will be a bigger effort, as all configuration options also start with `scylladb.`... (should we maintain backwards compatibility?) Moreover, the repo name should be changed to `scylla-sink-connector`...