auvred
auvred
Note: we should run both `test` and `test-eslint-base` scripts. Because for `test-eslint-base` the different test runner is used (Mocha instead of Jest). This is done so because `tests/eslint-base/eslint-base.test.js` is copied...
I'm +1 on adding some docs about snapshots and how to deal with them! In addition to ESLint output snapshots, we have rule schema snapshots. It would be nice to...
Yea, looks like `EmptyStatement` is missing in `Statement` union https://github.com/typescript-eslint/typescript-eslint/blob/074310029694f92323d4d91f0fd31df39698d0e7/packages/ast-spec/src/unions/Statement.ts#L34C13-L34C22 But `EmptyStatement` is part of `Statement` according to ECMAScript - https://262.ecma-international.org/14.0/#prod-Statement [playground link](https://typescript-eslint.io/play/#ts=5.4.3&showAST=es&fileType=.tsx&code=NxA&eslintrc=N4KABGBEBOCuA2BTAzpAXGYBfEWg&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false)
Note: it looks like https://github.com/typescript-eslint/typescript-eslint/pull/9038 already contains some changes in this area
Personally I'm +1 on recommending using `.mjs` config file with small note that it requires ESLint >= 8.57.0. Also see the related conversation on Discord: https://discord.com/channels/1026804805894672454/1207049165079846962/1213212499713728553
Oops, I kept in mind to mention deprecation in the docs, but it slipped my mind for some reason :smile: Thanks! It might be worth mentioning this in Rule Deprecation...
Fixed in https://github.com/typescript-eslint/typescript-eslint/pull/7375
Fixed in https://github.com/typescript-eslint/typescript-eslint/pull/7375 [playground](https://typescript-eslint.io/play/#ts=5.2.2&fileType=.ts&code=MYewdgzgLgBFCm0BiBXMwoEtwwLwwB4AVAPgAoA3AQwBsV4AuGIgSjxJmrvgG4AoBMjQZsYAmTa4OFEJgAm5Cexho58AGaYw8OS36hIsALZUADnhjaA7jACyZgtABOWgOYAaGEqmdZCsgDaALp6QA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge3oA99oBDWsX7RETVBgDa4bDkTRoHaJBkQAujIC%2BITUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false)
[prettier-plugin-tailwindcss](https://github.com/tailwindlabs/prettier-plugin-tailwindcss) released a new version that supports prettier v3 https://github.com/tailwindlabs/prettier-plugin-tailwindcss/releases/tag/v0.4.0 https://github.com/tailwindlabs/prettier-plugin-tailwindcss/issues/176