Lei Sun comments

Results 15 comments of


                                            Lei Sun

change private fields to protected in HiveMetadataWriter for impl to use

@hanghangliu Can you do following as part of regular practices for PR: - Create a JIRA ticket in the Apache board. - Adding the JIRA ticket number as part of...

[GOBBLIN-366] Adding retry into LoopingDatasetSource

@ibuenros Can you review it? Thanks.

[GOBBLIN-386] Optimize the memory usage of schema fetch in Hive Registration

@ibuenros @erwa Can you help review ? Thanks.

Gobblin 1320 add iceberg writer

Also, there's a travis failure

[GOBBLIN-1068]Clean up cyclic logic in task cancellation

@sv2000 Can you please take a look whenever you have time? Thanks.

[GOBBLIN-1068]Clean up cyclic logic in task cancellation

> @sv2000 Can you please take a look whenever you have time? Thanks. Looks like there's a code-change-irrelevant travis failure happening which couldn't be reproduced locally. Will trigger another build...

[GOBBLIN-1187] cancel flow execution when dag manager is disabled

The PR itself LGTM, but I don’t know indication of this change for the service itself, especially the backward-incompatible part. Will leave it to more knowledgable reviewers for this point

[GOBBLIN-797]Refactoring ConfigStoreUtils to make it not implementation-specific

@jack-moseley can you take a look ? Thanks.

[GOBBLIN-656] Add filtering of table format in HiveDatasetFinder

@htran1 Can you help review? Thanks.

[GOBBLIN-1398] load system specific hive config to support multiple h…

Hi Jay, thanks for this patch. Starting to look at it. Can you also update the your PR description for more context of what you changed as well as replace...