Roland Becker

Results 67 comments of Roland Becker

> Taking into account that you don't parse and load diffs but only commit messages it seems very slow I didn't have a deeper look, but did you measure that...

Concerning `function plugin_lang_get_with_help` Plugins are not the right place to introduce some kind of help concept. Such a concept should be introduced in Mantis core. The help string should not...

Not sure if you are aware that you don't search for custom fields of type `Text Area`. The values are stored in column `text` of table `custom_field_string`.

> Any reason why this one does not get merged? I am missing feedback / change for https://github.com/mantisbt/mantisbt/pull/629#discussion_r91238911

The filter should just be displayed if `access_has_bug_level( config_get( 'due_date_view_threshold' )`

@dregad right, access_has_bug_level is not the right function (copy/pasted from IssueViewPageCommand) But access_has_project_level() seems also not to be the right function for it, at least if "All Projects" is selected...

Looks good in general, didn't test.

Consider also that database setting can be utf8mb4 but the table is utf8. Maybe we should postpone utf8mb4 support until our minimum requirement is MySQL >= 5.5.35.

I am not sure if using Guzzle for this check is a good idea at the moment. Guzzle requires PHP >= 5.5 whereas we still have set `define( 'PHP_MIN_VERSION', '5.3.2'...

@dregad did you notice https://github.com/mantisbt/mantisbt/pull/1151#issuecomment-322240612 and [this note](https://mantisbt.org/bugs/view.php?id=23211#c57463)?