Mads Jensen

> Thanks for the PR @atombrella. Let us know if you need any help here or this is ready for review. @bmw I think some input on the approach is...

> I think changing the ACME account key is [supported by the protocol](https://datatracker.ietf.org/doc/html/rfc8555#section-7.3.5) but [is not by Certbot](https://github.com/certbot/certbot/pull/9139). I personally don't think we should try to change this here for...

@bmw I pushed some updates a couple of weeks ago. Intentionally, there are some failing tests where I don't really understand something. Mainly, `certonly` should register an account with LetsEncrypt?...

> > `certonly` should register an account with LetsEncrypt? > > Yes. The way it works now in master is if you run `certbot certonly` without an existing account, one...

It seems that the filesystem transport is not tested under Windows platforms. `test_filesystem.py` is decorated with `@skip.if_win32()`. The use of a context manager for the files should not require additional...

`@skip.if_win32()` doesn't have anything to do with either 32 or 64 bit. If you see the output from AppVeyor, the two tests from `test_filesystem` are skipped on all Windows platforms,...

> would you mind adding some unit tests & doc/release note entry for the changes? And add your name to author/contributor list if not already? In any case, the doc-string...

I left a rather rudimentary start at https://github.com/atombrella/testinfra/pull/new/firewalld Feel free to give input to what data that could be nice to be able to extract. As firewalld is a wrapper...

@zegl Could you please close this issue? It was fixed in #474

> Looks like the code doesn't compile anymore, I'm guessing that we need to make some alterations to our `sarif.go` to make it fit how the library is supposed to...