atoato88
atoato88
@justinsb This PR was created regarding #217, I think. Currently, #217 is merged, we need some updates for this PR. Could you update?
/remove-lifecycle stale
This PR has [`release-0.11` branch for v0.11.0.](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/208#issuecomment-1075074381) When we would like to use v0.11.0, we write in `go.mod` which use this repository following: ``` require sigs.k8s.io/kubebuilder-declarative-pattern v0.11.0 ``` I checked...
@justinsb Gentle ping.
/remove-lifecycle stale
/remove-lifecycle stale
In #199, any erros occured in reconciling are pass to [`Reconciled` function](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/199/files#diff-f4f154817e266917cf48c21f464818b16798c1d4e1170cee1af9804481f786f0R48). We may be able to utilize those error informations for updating status said this issue, I think.
/remove-lifecycle stale
Current codebase don't set ownerref to those objects; [refer this comment](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/2072cf081b2e512b687c6bf152466646df1ac2c9/pkg/patterns/declarative/reconciler.go#L582-L584). This was merged by #184
@xuzhenglun IMHO, labels set in `r.options.labelMaker` are quite important on some situations. e.g. Filter objects by those labels, ... @justinsb Any ideas which don't delete those labels?