Samuel Just
Samuel Just
I should get to this early next week.
This will probably need a few review rounds. Submit another PR with just the rename commit so that we can avoid rebasing that repeatedly.
+1 this seems like a good change generally!
@rzarzynski Maybe, but this is a somewhat risky change by backport standards. We'll want it to cook for some time in main and evaluate later whether the problem is sufficiently...
retest this please
I think we still need a teuthology test to inject these failures as mentioned above?
Does the test also validate that scrub correctly repairs the entries? Also, have you manually reproduced the original problem, upgraded to this branch, and validated that it handles it correctly?
This PR looks ok to me except for the above comment. I... can't seem to get github to let me approve it though, so consider this an approval!
@ronen-fr Ok, next step once this merges would be to work with qe to fully reproduce the original problem and validate that this fixes it.
I'll try to get to this on Monday.