atezs82
atezs82
One thing to add here is that - as you might have seen in the PR - is that, unlike the Kafka connector we are forwarding by entries which can...
> Can we separate the changes of introducing maxMesagesPerBatch config and the forward strategy feature into two PRs? I can do that if needed, will add a new one about...
I have modified the PR with the following: - removed different "forward strategies" (code and documentation) - we can have a separate PR for that in the future if this...
Yes. I will resolve the conflicts shortly. I was waiting for your opinion about the questions raised in https://github.com/streamnative/pulsar-spark/pull/63#issuecomment-996760872 before moving forward with this.
Rebased on top of master, now looking for a way to fix the Codacy warnings and do not increase the code complexity too much in the effort. Please in the...
I have slightly reworked some imperative logic inside to `TopicInternalStatsUtils` to a step more Scala-ish, please let me know what do you think. Thanks in advance!
@eolivelli Rebased on top of master, but I might have some additional work to do, since tests are failing still locally for `Apache Pulsar :: Tests :: Pulsar Kafka Compat...
Thanks for the comments, removed all non-Spark related changes from PR. Due to some issues, I still do not have tests working. I'm not sure whether this is a local...
@lhotari Thanks for the workaround, I have managed to run all tests successfully locally for the PR. @eolivelli Sorry for the mess, I have corrected the import statement.