Araik Tamazian
Araik Tamazian
Which parameters should be available to be set? Max gain and its position?
Can you assign this issue to me? I'll try to do it.
Should we let user specify `min_gain`, or should we set it to some constant value?
Thanks! As for now, I've have `min_gain` specified by the user.
Judging my your pics, you suggest using `min_gain = 1` in all cases, since the amplified signal (green) has the same level as original (blue) in the beginning. As for...
OK, I'll modify the code accordingly.
As for offset, I think that one can additionally use `Shift` augmentation if necessary. What do you think?
1. Actually it won't be the case since peak position in `GainPeak` is chosen randomly (it's not always the center) 2. Also won't be the case (see 1)
I also think that `min_gain_db` is a better option.
It seems that most people voted for the `min_gain_db` option. I suggest to close this issue.