Quentin Renard

Results 338 comments of Quentin Renard

@adeptedcase there were no progress on this issue and I won't have time to work on it anytime soon. I'm welcoming PRs though.

> Fixed the issue with the tests not passing. Thanks @eric, but as I mentioned in my previous comment, I'd rather go the [CorruptedPacketHandler](https://github.com/asticode/go-astits/pull/22#issuecomment-817102091) route in this case 👍

Requested changes need to be addressed (this was the first part of my review) but based on the fact that this PR is pretty old, I doubt the OP will...

Did you add a proper logger using [this option](https://github.com/asticode/go-astilectron-bootstrap/blob/master/options.go#L18) ? If not, could you add it ? Once you've done it, could you open the exe in the terminal and...

What logs do you see when you run `test.exe` through the terminal ?

Since you're using the `bundler`, you should use the `bootstrap` (check out the [demo](https://github.com/asticode/go-astilectron-demo/blob/master/main.go#L44)). In the code you've shared, you're not using the `bootstrap`, therefore `bundler` will be useless since...

@ayhangenc could you share the next 10 or 20 lines of the panic stack?

Can you open an issue including test data which would allow us to reproduce the problem so that it could be traced more easily?

This information is not accessible through this lib