Quentin Renard
Quentin Renard
Regarding the content of the PR, I don't really like the idea of ignoring the problem and rewriting the packet length. As you suggested [here](https://github.com/asticode/go-astits/issues/35#issuecomment-1018844668), I would implement the [CorruptedPacketHandler](https://github.com/asticode/go-astits/pull/22#issuecomment-817102091)...
Thing is, for `SectionSyntaxIndicator` doc says `Set when a PES, PSI, or DVB-MIP packet begins immediately following the header.`. Both `PMT` and `PAT` are `PSI`. Furthermore, `SectionLength` can't be trusted...
@barbashov this is really interesting ❤️ Even though it's the more complicated and weird way to solve this, your first proposition (partially parse PSI data in packet pool and store...
I've never used Github actions, therefore out of curiosity, would you say it's "better" than Travis? Why?
It seems file is in the administrator folder, are you using the administrator as well to open your app ?
The second line you pasted is weird : `https:/github.com/asticode/go-astilectron-bundler.git` It should be `https://github.com/asticode/go-astilectron-bundler.git`. My guess is you should run `go get -u github.com/asticode/go-astilectron-bundler` instead of `go get -u https://github.com/asticode/go-astilectron-bundler.git`.
I didn't think of this problem before but that is a good point. Do you have something particular in mind? I won't have a lot of time to work on...
@joeblew99 I think the problem is that the image is too big. I'll add a smaller image just for the tray and that should fix it
@joeblew99 I've updated the tray icon, should be better now (even though the image is ugly as shit :D). Can you confirm?
Sure, I can add more stuff to the demo. Can you be a little more specific about what you want me to add?