Assaf Shemesh
Assaf Shemesh
The changes are based on the work of PR after rebase, review and running the tests https://github.com/dagrejs/graphlib/pull/92
small question for my understanding, does this PR will deprecate the use of @types/graphlib as it will not be needed anymore?
Thanks for the reply, I believe that that's the right step in order to prevent version conflicts and more unless I'm missing something. I recommend of keeping the changes as...
My point is that this PR started with moving the type definition from @types/graphLib **as it is** and it seems like a good start that will help issue 84. (Sorry,...
Thanks for the comments and fast reply. No, I don't have a list of projects and we can't be really sure which projects are using it and how. I think...
Thank you @FunkMonkey, I highly appreciate your suggestion and reply. I don't have anything new to add but it's important to me to reply in order not to leave our...
Hi @dionyziz I'm trying to review the open PR in order to reduce the amount of issues and PRs. I reviewed your PR, nice work! Two main item that I...
Hi @mstou Thanks for the work! I'm trying to review the open PR in order to reduce the amount of issues and PRs. In case you want to continue your...
@mstou Thanks for the update, I will follow this PR.
@mstou Thank you for the new iteration. I ran your code and the tests passed. I left some small comments.