Andrew Speake

Results 10 comments of Andrew Speake

@aspeake plans on updating the `--alt_regions` default to `EMM` in a future PR

Fixed in https://github.com/trynthink/scout/pull/297 and will be further improved with https://github.com/trynthink/scout/pull/355

Depending on timing of https://github.com/trynthink/scout/pull/375, it may be good to update `fp.LOGS` path based on which yml is being run: https://github.com/trynthink/scout/pull/375#discussion_r1543487672

@trynthink do you think its important to be more clear about which files in ./generated belong to which yml/yml group? It is not at all apparent right now, but are...

> @trynthink do you think its important to be more clear about which files in ./generated belong to which yml/yml group? It is not at all apparent right now, but...

Companion ResStock PR: https://github.com/NREL/resstock/pull/782

> @aspeake We also discussed exposing the log file contents in the STDOUT so that it would be immediately visible in the runner logs, possibly by using verbose mode (which...

Remaining tasks - Revisit threshold for reporting diffs (is 10% and 1,000 correct?) - Add two columns to *_results_value_diffs.csv that show the original, absolute values to provide context for the...

@jtlangevin this is ready for your review (pending CI). Per your comment, I updated the absolute threshold for reporting to depend on the units being compared, where it is 1,000...

> > @jtlangevin this is ready for your review (pending CI). Per your comment, I updated the absolute threshold for reporting to depend on the units being compared, where it...