Azim Sonawalla
Azim Sonawalla
Note: I'm having trouble running the unit tests in this project (some of the shell scripts seem to not be properly escaping special characters in my snowflake password). Would appreciate...
Thanks @sfc-gh-jbahk. If I understand what you're saying correctly, there's a test somewhere that calls `getDigestAndSizeForStream` with a buffer that relies on that buffer being reset after the call. If...
Oh I see - the bind uploader calls the "put" command; I was looking for direct usages of the method. I'm still having trouble getting tests running on my local...
Whoops, `Reset()` on a buffer clears it, not seeks to 0, so the patch is wrong. I'll make some time to try again in the next day or two.
@sfc-gh-jbahk unfortunately I had to shift attention to some other work this week, but I do still hope to wrap this up soon. My plan is to get the tests...
FYI, I think I have most of the tests running successfully **on the master branch**, but still seeing this failure (which looks related, so I'm trying to avoid skipping it):...
It's on running `make test` on the repo root - [here it is](https://gist.github.com/asonawalla/583c88207097c64af1293e93f31ece97#file-gistfile1-txt-L715-L717) in context of the rest of the output.
I actually just noticed that there's [another failure](https://gist.github.com/asonawalla/583c88207097c64af1293e93f31ece97#file-gistfile1-txt-L338-L341) in there, but just based on the names of these tests, that one seems less important to get right for this change.
PhantomJS might be a good candidate to use here http://phantomjs.org/