Ashmeet Lamba
Ashmeet Lamba
Hi! I believe this is a contribution for Hacktoberfest. This will not really help in improving the whatever small project this is. What I can do is help you in...
@dengziming since you raised the JIRA ticket for [KAFKA-14073](https://issues.apache.org/jira/browse/KAFKA-14073), would please review this PR.
@dengziming I have made the changes requested. I have also made the changes in `QuorumController.maybeGenerateSnapshot` to log the reason for the snapshot being generated. `maybeGenerateSnapshot` seemed to be a better...
Hi @dengziming, could you review this once more? I have made the requested changes.
@dengziming I have made the requested changes and added the sample logs in the description of the PR.
Got it, working on these changes. Taking a bit of time to go through the code.
Hi @jsancio, I have defined an enum in the raft module for `SnapshotReason` and have used it in place of string messages that were being passed previously. I am working...
Thanks @jsancio, this is helpful. I'll go ahead and make these changes!
Hi @jsancio, just one another doubt - Does this mean we don't want to log the reason within `KafkaMetadataLog` and keep the logging as it is right now within `BrokerMetadataSnapshotter`...
Hi @jsancio, I have reverted the changes made to `RaftClient` and kept the logging withing `BrokerMetadataSnapshotter` and `QuorumController` I have two questions, would really be helpful if you could guide...