Ashley Nelson
Ashley Nelson
> Looks like there are some new test files here, test/multi-memories*? It would be good to make those wast files instead of wasm, unless I'm missing a reason not to?...
It might be clearer to make this more explicit by doing something like `memory->max = maximum == -1 ? Address::kUnlimitedSize : maximum;` (although I see this was preexisting code). _Originally...
It's more efficient to use the existing unique ptr rather than releasing it just for a new one to be created inside `addExport`. ```suggestion - ((Module*)module)->addExport(memoryExport.release()); + ((Module*)module)->addExport(std::move(memoryExport)); ``` _Originally...
We should also do something with any existing memory exports. Probably deleting them makes the most sense, but that would be a functional change, since previously they would have implicitly...
Mid to late June please & thanks
I would prefer June 11 - 13 or June 18 - 21.
All of the dates in July & August work for me.
Binaryen has arguments for the necessary memory immediate on SIMD and threads. GC doesn't have memory needs afaik, but you're right, Binaryen has no support of multi-memory in stringref. Let...
8 tests are failing because updated imports/exports are missing. The changes in https://github.com/WebAssembly/binaryen/pull/5363 need to be submitted first.
One emscripten wasm-split test is failing, `other.test_split_main_module`: `failed to asynchronously prepare wasm: LinkError: WebAssembly.instantiate(): memory import 14 is smaller than initial 257, got 256`