ashlen

Results 54 comments of ashlen

What difference does this actually make? I feel like the exact time wasn't even given. Might be a good idea to find out what timezone it uses since most of...

Maybe add a link to the CLI section of the docs rather than putting it directly into the README. You can then add all of these changes to the docs.

I had no luck reproducing this error. Hopefully, this will be consistently fixed with the new upcoming model library.

Do they show up immediately after doing the floor and checking the hoyolab app? There used to be a 1-hour delay.

Guess this should be documented. I don't want to force users to make an extra request arbitrarily.

Not too sure how to go about that considering there's no documentation for how the cookie is made. Best I could do is check for ltuid to be numeric and...

I'm all for making patching easier but I'm not sure if this is truly the best approach. Storing raw values should be possible with a root validator in the base...

This will be fixed by removing the pydantic dependency and switching to [a custom model library](https://github.com/thesadru/apimodel). Development is slow but it's being worked on.

Alright I know I have said that giving away your cookies may not be that detrimental but at the same time, you're making it seem way too safe. While it...