Ashish Singhal
Ashish Singhal
Hello, You can try the following: 1. If you’re using a debug build, consider switching to release build so that time spent logging messages over uart is saved. 2. Reference...
Hello, You can do it in two ways: 1. In the UEFI DTB, disable the I2C controllers that you know you would not be using on your platform. 2. In...
Hello, I am not sure I am able to understand the goal of what you are trying to do. NV UEFI reads all EEPROMs based on information in eeprom-manager node...
Hello, Let's go over the issues one by one to be able to handle them better. My comment will be purely from the perspective of NV providing UEFI for its...
Hello, Thanks for your feedback. Lets again go through them one by one. 1. NV would make a change to allow a PCD based skipping of CRC check in EEPROM....
Let me reply issue by issue: Issue 1. Both approaches yield the same result. I would define a property /firmware/uefi/skip-eeprom-crc in DTB which can be used to skip CRC check...
Thank You. Please try to have the commit message in the following format so that I can use it as is. Also, please add signed-off-by tag as well. fix/chore/feat: title...
Thank You. I will review these in a few days. I will need to rewrite the commit message to follow the NV format more closely.
We use uncrustify as in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting
Hello, Please update the commit message to have the fix/feat/chore in small case. The title should be approximately 80 characters and the description say 100 in one line but you...