Ashley Gillman

Sorry for the slow feedback. NixOS tends to move pretty fast, and locks with releases, so as long at the latest version is supported at any given time, no worries.

> find_bin_given_cartesian_coordinates_of_detection (replace with get_bin(LOR&)). Used in #618 Renames to `get_bin_for_gantry_coordinate_pair`. Should this still be replaced? > find_scanner_coordinates_given_cartesian_coordinates (replace with get_LOR or get_LOR_as_2_points). Used in #618 Renames to `get_det_pair_for_gantry_coordinate_pair`. Should...

FYI @NikEfth @danieldeidda @NicoleJurjew @Ede1994

I've tried and failed at testing each of the following: ### mCT LM data `lm_to_projdata` fails - "`CListEventECAT8_32bit can only handle axial compression==1`" https://github.com/UCL/STIR/blob/59ab3eadadfe514fa5d4a823a6db305c9193567a/src/listmode_buildblock/CListRecordECAT8_32bit.cxx#L43-L46 This is regardless of the template...

Update for the Vision 600: I had to add `%axial compression := 1` to the Vision LM data - but it seems this isn't in there by default. Now a...

ProjDataInfoCylindricalNoArcCorr.cxx  Chosen strategy: It seems ToF adds some extra swapping for rings and detectors. Respect this, while allowing updated to_0)2pi stuff: 

Scanner.cxx  Related to #181, 8b648897ff2a22157cf54cbac0d7fdde82c801ab @KrisThielemans not confident on this one, but it seems just to keep the master version? 

> > MLnorm.cxx > > Chosen strategy: > > Keep the functions > > incorrect. `set_fan_data` has been superseded by `set_fan_data_add_gaps` and similar with `make_fan_data_remove_gaps`. The modification is at the...

Bin.h  Resolution: Keep both 

Bin.inl  Resolution: We're happy to not have a constructor for `time_frame`? Just add `time_frame(1)` to each