Anthony Seure
Anthony Seure
Same issue here. My environment: - macOS High Sierra - iTerm2 3.1.4.beta.1 - Vim 8.0.1200 - Easymotion 342549e
That's seems really reasonable to me and a very good move towards: 1. a state-of-the-art .NET library by using this soon-to-be widely adopted JSON serializer 2. a dependency-free library which...
I'm not as proficient in C# as you, so I'm not aware of any other simpler solutions than the manual conversion. This still has the drawback of not enforcing the...
Referencing our main task to keep track of this issue' status. https://github.com/algolia/algoliasearch-client-specs-internal/issues/30 **edit:** dead link updated (still private though).
Not needed to implement it as the DSL is already simple enough, however we will need to document it.
Specs available here https://github.com/algolia/algoliasearch-client-specs-internal/issues/30
As [confirmed by @nunomaduro](https://github.com/algolia/algoliasearch-client-specs-internal/issues/42#issuecomment-526526444), not only `condition` becomes optional, but also `condition.anchoring`, `condition.pattern` and `condition.context`.
Disclaimer: I'm not sure of all the implications it would have. My initial thought is that it could lead to users reporting issues with failed serialization/deserialization of legit Algolia requests...
Same issue here. We've switched to `cross-fetch` as well which solves the issue for us. FYI we've made it work with `isomorphic-fetch` with the following configuration but we thought it...
Hey @Korben00 and @LeoColomb. Thank you very much for the contribution and your time here. While we would like to better support PHP 8 in the future, an important user...