asanin-epfl

Results 12 comments of asanin-epfl

@lidakanari please what is the status here? Can you provide a draft?

I'm afraid that `morpho.soma.type` is read-only. ``` Traceback (most recent call last): File "/Users/sanin/workspace/MorphIO/deleteme.py", line 23, in morpho.soma.type = morphio.SomaType.SOMA_CYLINDERS AttributeError: can't set attribute ```

No worries > To me the important thing is that we have the correct type when you write the file in a given format and then read it again. I...

`source_node_id` and `target_node_id` must have node population names in their attributes, no?

Yes. That's why I mentioned libsonata at the end of my comment. I created this issue for information only as inquired by @mgeplf.

Test is not necessary and is up to you. I see there are plenty of `@cached_property` used. Should we consider them also?

This problem suddenly became ~~critical~~ not anymore, it is due to my code in the end. ~~It happens on PizDaint with the currently deployed version of sonata-network-reduction ([email protected], [email protected])~~ The...

seems fine to me.

> I'm wondering w.....d (which is currently not the case). Does that work for you @asanin-epfl? Yes! Pickling would be also great but not critical. I've managed to live without...