Ali Saad-Eldin
Ali Saad-Eldin
Problems that GM is solving: - Vanilla GM (part of GraphMatch) - Soft seeds (probably part of GraphMatch) - Soft group seeds (probably part of GraphMatch) - divide, merge, and...
> @asaadeldin11 thoughts? any reason to have it be a class/function? I think it can work as either; the scipy version has a bunch of optional parameters, and returns an...
looks like theres some formatting issues but the rest looks fine to me.
@jjerphan Thanks for the review! I'll try to address your comments as soon as possible.
@jjerphan Apologies for the delay, but I believe I've now addressed the comments in your previous review!
@jjerphan Hope all is well! Just checking in on the status of the PR.
> Before giving a comprehensive review, I think it's worth clarifying the code licensing. > > If this code is originates from `microsoft/graspologic`, we need to include the MIT license...
For the PR itself portion, maybe mention that new features should include proof of effectiveness, like a jupyter notebook that replicates a figure from a paper