arwer13
arwer13
Assigning the role to Voting was introduced in https://github.com/lidofinance/lido-dao/pull/807 to skip adding voting-related code to `scripts/scratch/checks/scratch-acceptance-test.js` The plan is to remove assigning the role after voting-related code is available at...
It is `stETH Withdrawal NFT` ([see WithdrawalQueueERC721](https://goerli.etherscan.io/address/0xCF117961421cA9e546cD7f50bC73abCdB3039533#readProxyContract#F37)) although must be `Lido: stETH Withdrawal NFT` as on mainnet. Can be fixed only by redeploying of the implementation, because the value is...
1. Achieve 100% function and branch coverage as reported by `yarn run hardhat coverage` 2. Cover all branches from `auth` modifiers (**NB**: they are not caught by hardhat coverage utility)...
Unify across all the contracts. E. g. in the snippet below the asterisks are aligned at the middle symbol of `/**` but there are also cases where they are aligned...
Based on [this comment](https://github.com/lidofinance/lido-dao/pull/401#discussion_r875378512) The starting idea was just to move emitting `Transfer` and `TransferShares` events into `_transferShares` function to reduce code duplication. But doing so also requires significant changes...
This PR duplicates fork changes provided by https://github.com/txfusion/lido-l2/commit/0c6214d20f18186a6eb2cdfb1b42f50761f2dc5d to add more redundancy in keeping track of the code deployed on-chain. It is not planned for merging (at least yet) due...
This PR duplicates fork changes provided by https://github.com/mantlenetworkio/lido-l2/commit/75e023ad54fc93de7f44d5c80339a3d59c4c7d31 to add more redundancy in keeping track of the code deployed on-chain. It is not planned for merging (at least yet) due...
There are two vote item descriptions: 1: ```reference="Initial DAI funding Pool Maintenance Labs Ltd. within Nov'22-Apr'23 budget",``` which goes into Aragon Finance NewTransaction event 2: ``` vote_desc_items = [ "1)...