Arun Koshy
Arun Koshy
> 1. I would expect a change to the .proto, to make it explicit to callers they do not have to provide this information, is that possible? Proto3 fields are...
Just to clarify `BlockWaiter` returns ``` pub struct GetBlocksResponse { pub blocks: Vec, } ``` ``` pub struct GetBlockResponse { pub id: CertificateDigest, pub batches: Vec, } ``` ``` pub...
Everything looks good to me the only thing I am curious about is your switch to separate fields instead of a nested repeated `oneof` > the complexity that the current...
I don't mind changing it, but my argument to keep it would be because both fields in this case are mutually exclusive per `collection_id`. So it makes sense to use...
I began playing around with tonic last week and was looking into seeing if they have some examples of alternate network channels other than HTTP. I couldn't find anything so...
This is a very good question and I have no reasons for why we couldn't use a loopback address as it would never hit the network. Maybe this will remove...
PR as it stands is no longer required now that [PR#4628](https://github.com/MystenLabs/sui/pull/4628) has been merged. Will move the `worker_info` messaging in `PrimaryReceiverHandler` and the tests in separate PR.
I began playing around with tonic last week and was looking into seeing if they have some examples of alternate network channels other than HTTP. I couldn't find anything so...
This is a very good question and I have no reasons for why we couldn't use a loopback address as it would never hit the network. Maybe this will remove...
> How do we fix this? The simplest way I can think of is to modify the ReliableNetwork trait (at least), and modify the broadcast function there so that we...