Arturs Vonda
Arturs Vonda
When using with regular dump command, $previous will be empty and thus will dump all the files. I left it there for consistency.
@kriswallsmith any feedback or are we good to merge this?
Bump comment. What's holding back this PR?
I rebased my PR. There are some failures in tests, but looks like they are because dev-master version of some of the symfony components where used (meaning, Symfony 3.0 components)....
The issue is not on my end and I'm not sure if the issue is with Symfony component versioning or composer. The composer.json file looks correct.
Any news on this? Came across the same issue.
This is an issue for us as we don't use `get/is` prefix for getters. And this breaks criteria on array collection. By the way, the only issue for me here...
@ljharb, good point on naming, definitely could change. We could even be very specific in name that this is about `index-as-package-boundary`.. > “contains an index file” in no way indicates...
> Can you help me understand why it’s a good rule of thumb? Deep imports are objectively superior to always importing from a manifest file, since it obviates the need...
That's true, but I think that's at the expanse of maintainability and encapsulation which at least to our team are very important. And with proper tree-shaking there shouldn't be any...