Harsha Goli
Harsha Goli
Wrapped all the known bugs listed initially, and addressed all PR comments. Ready for another pass!
Did another pass, couldn't find the merge commit you mentioned (maybe I unintentionally undid it? I've been rebasing like crazy) -- please confirm. In any case, I did rebase to...
At the point the only lingering bit is the addition of `FetchOutgoingChannelEdge` for unit testing purposes
Addressed all comments, redid the commits to work itests into their proper commit messages! Anything left at this point?
Just did another pass! Was unable to get my docker setup up and running locally, so I'm relying on CI tests atm
Finally came back to this one, PTAL!
> The channel closing transaction has only one output, which holds all the sats I expected, as if the loop out did not happen. It sounds like the loop out...
Ah I see the title now, appears it is failed. Please provide the logs requested in which case
note: the following oneliner is useful for hunting this flake ``` while /usr/bin/go test -count=1 -timeout 30s -run ^TestAutoLoopInEnabled$ github.com/lightninglabs/loop/liquidity; do :; done ```
Looks like this flake was introduced by the initial test, maybe we should add a flake hunting step in our ci @bhandras? Just run every test 20 times or something?