Andrew Rogl

Results 35 comments of Andrew Rogl

> I am using a third party downloader module. It looks like the issue is with the downloader. I am looking for a solution, I will probably try changing a...

> > > @ansonsiva The varying speed is not the issue, it is about what download speed you get on average. If it drops to 10KB/s it should get up...

I found the following, so it seems a limitation of pythons implementation of zip extraction: https://stackoverflow.com/questions/9813243/extract-files-from-zip-file-and-retain-mod-date

I will try to look at all file extraction from archives over the weekend. I was thinking of wrapping the time setting while only the preserve options enabled

@sampsyo Could this work? In [importer.py#L1080](https://github.com/beetbox/beets/blob/master/beets/importer.py#L1080) add ``` py # From here: # https://stackoverflow.com/questions/9813243/extract-files-from-zip-file-and-retain-mod-date # fixing #4392 def RestoreTimestampsOfArchiveContents(archivename, extract_dir): for f in archivename.infolist(): # path to this extracted f-item...

> By doing it this way are we setting the times also in the cases where they are already set by the unarchiver? Just curious. At the moment every extraction,...

Initial change Still to do [ ] test which archive types do not keep mtimes [ ] how to check whether preserve_mtimes is set

> Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? > > This pull request has been automatically...

This should be an easy pull, as it mimics normal unzip behaviour of extracting files with times from the zip file. Python unzip does not modify the files date when...