Alexey Rogachev

Subscribing button - allow not only text

3

Button can be for example simple icon without any text with bell changing to icon with crossed "X" for unsubscribing. Or like in my case it can contain both icon...

Subscribing - consider existing subscription

2

When page initially loaded, `subscribe` button is shown regardless of user already subscribed or not, This is not user friendly interface. At least we need to check if user already...

Get rid of global variables and methods in webpush.js

2

Currently these variables are in global scope: ``` js var isPushEnabled = false, subBtn, messageBox, registration; ``` Also these methods: `subscribe`, `unsubscribe`, `postSubscribeObj`. This is a bad practive especially because...

As I said in #16 in this [comment](https://github.com/safwanrahman/django-webpush/pull/18#issuecomment-252538177) maybe it will be better to have just basic functionality in JS and not force user to use specific UI because it's...

Allow translations in subscribing UI

2

Currently all informing messages for user are hardcoded as js strings, for example: ``` js messageBox.textContent = 'Service Worker is not supported in your Browser!'; ``` Translation to different language...

It will be better if the code will follow [PSR-2](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md). Yii2 follows it and recommends to follow it in extensions. Among the errors I saw for example extra spaces before...

Incorrect detection of summary

4

Extracted from #282. Reporter - @WinterSilence, see https://github.com/yiisoft/yii2-apidoc/pull/282#issuecomment-1080587912.

Misleading error about relative link in errors.txt

3

Found during running `make download` for site, UK language. ``` Using relative link (https://www.php.net/manual/en/function.PDOStatement-setFetchMode.php) but repoUrl is not set. ```

(PDF guide) On each even page content is slightly shifted to the right

5

### What steps will reproduce the problem? Download [PDF guide](https://www.yiiframework.com/doc/download/yii-guide-2.0-en.pdf) or generate it. ### What's expected? The same indentation on each page. ### What do you get instead? Different indentation...

inheritdoc works correctly only if a closest parent has actual description (methods)

1

Extracted from #194. Reported by @neoacevedo. ### What steps will reproduce the problem? https://github.com/yiisoft/yii2-apidoc/issues/194#issuecomment-990093808 ### What's expected? Replaced description from a parent method. ### What do you get instead? ```...