Arnaud DUDES
Arnaud DUDES
This PR is related to the #3179 and not the #3014.
@TotoGaz Thanks for your feedback, in reply to your suggestion : Would a highly coupled class be an issue? Group would only have 1 attribute & 1 getter for this...
> i seems that this is not based on `develop` but some other branch because there are much more changes than in the description Indeed, it was based on the...
> > > i seems that this is not based on `develop` but some other branch because there are much more changes than in the description > > > >...
@paveltomin Would it be possible to review [PVT PR ](https://github.com/GEOS-DEV/GEOS/pull/3149) as this is the oldest one and the priority PR for our users. As a said earlier, this PR is...
> what is your definition of Section? since GEOS does not have Section concept, it should be clearly defined, otherwise it's quite arbitrary how one can do the split it's...
Yes, we define a section object in the section code, for example : ``` Section section( "Mesh generation" ); section.beginSection(); generateMesh(); section.endSection(); ```
@rrsettgast @paveltomin Myview is that Sections should separate the main initialization & destruction steps of the ProblemManager, and each simulation timesteps. I added the Sections I identified in the PR...
do not merge : display not good when using mpi
smw I'm getting this kind of error in integrated test : `Scalar values of types int32 and int32 differ: 4, 6`