Arnav kumar comments

Results 6 comments of


                                            Arnav kumar

Fix: Add try/catch around stat() in Windows symlink logic

can you please review it @technoweenie @mojodna @bmizerany

Fix: Add try/catch around stat() in Windows symlink logic

Hi, this PR adds a small defensive try/catch around `stat()` in the Windows symlink code path. This avoids a rare synchronous crash when `stat()` throws on certain Windows setups. It’s...

Fix: Add try/catch around stat() in Windows symlink logic

@aduh95 please review it.

Fix: Add try/catch around stat() in Windows symlink logic

@legendecas. "Added test case in test/parallel/test-fs-symlink-windows-error-handling.js that verifies the symlink creation handles stat() errors gracefully on Windows. The test creates a symlink with a relative target that would cause the...

fix: add ASAR support for Node.js fs.cp methods

> 1. Could you please confirm whether you have built and tested these changes? > 2. Could you please add tests? 1.I've added tests and verified the code follows existing...

fix: add ASAR support for Node.js fs.cp methods

The requested changes have been made. Tests were added, and release notes have been updated. Please let me know if anything else is needed.