Arman Bilge

Results 1747 comments of Arman Bilge

@LironEr thanks for the heads-up, much appreciated! I've made the changes in https://github.com/armanbilge/sbt-bundlemon/pull/11 and verified them against your test environment. Seems to be working, so let me know when it's...

That's a great point. Unfortunately not in this PR, since it seems that the Java Stream is implemented in terms of the Scala one.

Seems more appropriate as an issue? Since it applies to the entire project, no? :)

Same problem for 2.11 artifact. ``` $ wget https://repo1.maven.org/maven2/org/scala-native/nir_2.11/0.4.5/nir_2.11-0.4.5.jar $ less nir_2.11-0.4.5.jar | grep Volatile 1864 Defl:N 892 52% 2010-01-01 00:00 b6a48d13 scala/scalanative/nir/Attr$Volatile$.class ```

@keynmol so actually I began by investigating the source jars to see if it matches the bytecode, but actually they are inconsistent (the sources match v0.4.5 and not the v0.5.x...

> Arman, in the spirit of process improvement, not antagonism, with your go ahead I can submit a WIP PR for consideration to make ideas easier to review and compare,...

Nice! You may want to target this PR at the 0.4.x branch if you want it in the next release :)

> 2\. On a hasty read, it looks like the current implementation would work in > `InputStream`. @LeeTibbert possibly, but see my comments in https://github.com/scala-native/scala-native/issues/2774#issuecomment-1206583639. The problem is that for...

I don't think this PR should be closed at all :( it is a good contribution. @fiatjaf I'm sorry you felt like you are causing trouble, that is not at...

> Consider `FileInputStream` today. It has a method, which is implemented > in Scala Native. `int read(byte[] b, int off, int len)`, which can block. This is analogous > to...