Aaron Renoir
Aaron Renoir
PR #343 fixes this issue.
@alejandrodevs the backed does return a 401 and the ember-simple-auth used to handle the error using the application route mixin. Should this error be handled in the application route or...
@alejandrodevs thank you. This should be added to the readme.
Something else to note I am requiring authentication in the the application route beforeModel hook like so. ``` beforeModel(transition) { if (transition.targetName !== 'login') { this.session.requireAuthentication(transition, 'login'); } } ```
@sacarino, yes I am using a custom authenticator. This is a good bit of information. I haven't had much time to investigate but let me know if you get anywhere.
I believe it is correct to append the rootURL to the path as the sw.js and sw-registration.js files are not asset files but rather application files. The difference being asset...
Okay good to know. If the sw-registration.js file is fingerprinted then shouldn't it be treated like every other asset file and the rootURL not appended?
https://ember-cli.com/user-guide/#deployments "the asset URLs will not use rootURL and will instead be: https://cdn.example.com/assets/vendor-3b1b39893d8e34a6d0bd44095afcd5c4.js."
Thanks @martndemus for the suggestion. I started to refactor the add-on to omit the rootURL from the sw-registration.js src if the fingerprint prepend option is present. But because _getRootURL() function...
@eshtadc it looks good to me. I will pull it into my application and give it a try.