Dagan McGregor
Dagan McGregor
I am working on making updates to fix this PR. I need to check it works with what we have deployed. I think the tests are failing because they are...
> Could you add documentation strings? For example, what's the difference between `$stream_format_log` and `$stream_log_format`? It has been a while since this code was written, and we're not using `stream_format_log`...
@ekohl the tests on this PR have expired so cannot see what the failures are. Are you happy with the comments above?
> This issue is similar to #444 I can workaround the bug, by adding an empty file to moduleroot. IMO. this shouldn't be required. Workaround required based on the current...
I tried microdnf for a minimal container when I read this article https://fedoramagazine.org/building-smaller-container-images/ When I tried to use microdnf to install the rpmfusion packages it failed. It didn't like either...
@kenyon is it possible for you to do a fresh review for this to get merged? It appears the documentation has been added, and this is much needed improvement for...
@Henrik-Hansson if you are still keen to update this pull request, the version check could use a tweak. RHEL9 started with 1.20, a version check for this should fix the...
Updated with suggested changes
> I am working on making updates to fix this PR. I need to check it works with what we have deployed. > > I think the tests are failing...
@ekohl I have added a basic set of tests to cover the main use case for the stream access log. Appreciate if you could give another review