Archit Kulkarni
Archit Kulkarni
@edoakes I addressed the comments, please take a look
Linkcheck failure: ``` -- | ( index: line 21) broken https://img.shields.io/twitter/follow/raydistributed.svg?style=social&logo=twitter - 403 Client Error: Forbidden for url: https://img.shields.io/twitter/follow/raydistributed.svg?style=social&logo=twitter | ( index: line 17) broken https://img.shields.io/badge/Discuss-Ask%20Questions-blue - 403 Client Error:...
@shrekris-anyscale @edoakes @sihanwang41 @simon-mo This is still rough, but is ready for an initial content review. I've left some questions and comments as "TODOs" that I need to resolve, but...
@stephanie-wang Thanks for the review! Addressed/responded to the comments, could you please take another look?
Some CI jobs tests failed, e.g. https://buildkite.com/ray-project/oss-ci-build-pr/builds/431#01837a6f-fb4c-4e09-97e4-c9a57fdb10c9/3394-4825 , could you please take a look?
@Catch-Bull Possibly relevant failure? https://buildkite.com/ray-project/oss-ci-build-pr/builds/566#01837fbf-2e34-449b-8125-1834439b9e51/3305-3805
The cpp fix might be simple, we just need to add support for `address="auto"` to C++ drivers, or simply ignore `address="auto"` if we see it (maybe we can just ignore...
Also, we should make sure the C++ job test gets run even when there are changes to the Jobs code, even if there are no C++ changes
There's another type of flakiness: https://buildkite.com/ray-project/oss-ci-build-branch/builds/304#01839baf-cf05-4e32-a4b4-88608e7e9e0a ``` E File "/Users/ec2-user/.buildkite-agent/builds/bk-mac1-branch-queue-i-0428bb49501460ad6-1/ray-project/oss-ci-build-branch/python/ray/dashboard/datacenter.py", line 234, in get_all_agent_infos -- | E grpcPort=int(grpc_port), | E TypeError: int() argument must be a string, a bytes-like object...
@rkooo567 no need to review the whole PR if you're busy, I'm mainly curious if you know a better (more lightweight) way to get the GCS address from a `ray://`...