Artem Riabokon

Results 10 comments of Artem Riabokon

@adriancole Sure, no problem. Trace JSON: https://gist.github.com/archie-swif/81ea16a55ae9dccf3f2505257f2beac4 Logs: https://gist.github.com/archie-swif/2e98e07fb667ff391ed36e5b2402a211 That's how it looks in Zipkin. There is only a single TWO span for some reason, for the exact scenario.

In the JSON I see that there are 4 get records for app TWO, with the **same** Span Id ddc5003cea7888a7 ``` { "traceId": "bbf04ad17fce973c", "parentId": "bbf04ad17fce973c", "id": "ddc5003cea7888a7", "kind": "SERVER",...

I would expect get TWO records to be nested under get ONE's Span, this way: Expected JSON: https://gist.github.com/archie-swif/5170bfd5118cf0b66e128607aea0727b Imported in Zipkin:

It looks better with 2.1.0.BUILD-SNAPSHOT spring-boot-starter-parent. But still has some problems. Trace JSON: https://gist.github.com/archie-swif/513bcf9cc97a87938f2491bca0d950c8 Logs: https://gist.github.com/archie-swif/10282e2039c232b9b2889028e06ffd5f

So, 2.1.0 snapshots did not help with for this issue

However I see that Span IDs in TWO's logs are now unique Let me take a closer look

With 2.1.0 Snapshot, ID assignment has changed. Now each WebClient GET call on app ONE opens a span with unique id. And app TWO code is executed in the span...

There was an expected picture bit earlier, with two “get” bars under each “async”. https://github.com/spring-cloud/spring-cloud-sleuth/issues/1121#issuecomment-435275230 Now Id is unique for each call, but is duplicated for “get” in scope of...

Hi @marcingrzejszczak , thanks for checking up! I have tried it with Spring Boot 2.3.2.RELEASE, 2.4.0-SNAPSHOT, and latest zipkin image 2.21.5. Here is how it looks by default: I see...

In 2.4.0, additional "async" span is being tracked, but ONE's "get" span is still ignored, even if it's present in json. After id fix it looks this way: