Artur Wojcik
Artur Wojcik
> Can we just use the `-Wl,--no-as-needed` flag instead on windows? It is not supported on Windows. It is only applicable to shared objects.
> Also, we could make `migraphx_all_targets` a static library and then have it load the all targets before `main`: > > ```c++ > __attribute__((constructor)) void load_targets() > { > make_target("ref");...
I managed to simplify the PR and limit the number of required changes.
@pfultz2 it is done
@causten CodeCov reposts a 0.01% test coverage decrease. However, when I look into the pull request details, it says that the patch is 100% covered. Am I reading it wrong?
> @apwojcik are we still working on this change requested? Yes, but currently, I have other priorities. I will be back to this PR.
@junliume, please ignore the Windows build failure; the #3043 will fix that.
> I don't think that `setEnvironmentVariable` is required at all, it was misused in the tests and must be removed, but now it is even widely used. `env::update(VAR, value)` must...
@junliume, please ignore the Windows build failure; the #3043 will fix that.
> @seungmanhan @apwojcik The Windows build is failing while the Linux side is passing: > > > lld-link: error: undefined symbol: enum miopenStatus_t __cdecl miopen::GetitemBackward(struct miopen::Handle &, void *, unsigned...