Juan Cruz Fortunatti
Juan Cruz Fortunatti
I've pushed some updates to the code.
Hello @neSpecc, @gohabereg ! Could you give this a look ? I didn't find the CONTRIBUTE.md so I just went with it and sent the PR... let me know if...
Thank you again for the review ! I have just addressed the all the issues. Let me know what you think @neSpecc.
I have resolved the conflicts.
Done @neSpecc. I have restored the file to it's original state in [4d4718f](https://github.com/codex-team/editor.js/pull/2019/commits/4d4718f51abfcbceb91157b6e1e9d58175ed34f6) and then added the changes back to it in [776cb21](https://github.com/codex-team/editor.js/pull/2019/commits/776cb21407fc8510d632b33614d2bc2ba71f5716). Is this enough/the correct way ? Otherwise...
Hi @neSpecc, is there any pending change on my side ?
Awesome. 1. We can go ahead and roll back those, I'll just need to add a few lines (4) to make the line to on top or at the bottom...
Something like this: https://codesandbox.io/s/dark-voice-hd8lrh?file=/src/App.tsx
Alright, I don't really see any another solution on how to set the image... I tried to create an in memory svg element with the block inside but I wasn't...
Well, @neSpecc it seems like you can do it without creating an image by just setting the element to the setDragImage function: https://codesandbox.io/s/intelligent-hofstadter-k1gpyf?file=/src/App.tsx The [documentation](https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/setDragImage) of the function says >...