apple502j

Results 185 comments of apple502j

@haykam821 `multiplyComponentwise` might be from `Vector4f` - but this one should be named `scale` or `multiply`.

Those are not obfuscated, can yarn actually fix them?

"Biggest" refers to the attack, not the attacker.

Hmm, there's also "opaque", "solid", "not solid", etc in those code. Perhaps javadoc it?

@liach Yeah, but no instantiatable class should be called helper.

@liach Unsure. Almost all changes are to chat and networking stack plus some allay changes, there are little to no changes required for others.

Given we've been doing some sort of rendering code refactor in snapshots it makes sense to fix there. Hmm, I can try make a PR from GitHub Mobile I guess?...

Update: Seems like individual classes are still called "loot conditions"/"loot tables" by Mojang. Managers need rename, others probably not.

@liach Hmm, that looks too short for an important class, and it's also weird if `VersionedChunkStorage`, etc was a parent of `ChunkStorage`. `ServerChunkStorage` could work though.

@sfPlayer1 I understand this handles more than storage (e.g. entity loading, storing chunk generator) but the main purpose is that. I don't really see a better name for this (aside...