Lars Müller

Results 677 comments of Lars Müller

> Any suggestions? See my review comment above: Leverage modular arithmetics to keep your numbers small. [Example from my Lua implementation of the Miller-Rabin primality test](https://github.com/TheAlgorithms/Lua/commit/fbb50893725534b8795e430d927a384e6349692e#diff-f3f9c6855ba634d8777a1b3b8ed41452753b598d105bc1eac012354f7823c140R4-R14).

> In my opinion, this is largely a duplication of the [`PrimeCheck`](https://github.com/TheAlgorithms/JavaScript/blob/master/Maths/PrimeCheck.js#L9) function. Using the fact that all prime numbers other than 2 and 3 are in the form 6n...

> > You should remove the isComposite function and instead make your changes to the PrimeCheck function. > > What changes should I make? I am a bit clueless... I...

> Hmm, I still do not quite understand. PrimeCheck checks the prime number while the IsComposite checks the composite number. Yes, what the algo doing was reverse of each other,...

I agree with rubenwardy. Users have already started to write [insecure "extensions"](https://forum.minetest.net/viewtopic.php?f=14&t=22313) to the mainmenu. I would propose allowing some sort of "master key" which is used to hash your...

> Here are some credential storage systems that can be interfaced by applications to store and request credentials. > > macOS https://en.wikipedia.org/wiki/Keychain_(software) > KDE https://en.wikipedia.org/wiki/KWallet > GNOME https://en.wikipedia.org/wiki/GNOME_Keyring > >...

> also i suggest to add a device id to minetest. No. This is not in the spirit of free software. > this id should be derivated like ms copy...

> It's been over a year... Unfortunately the PR isn't in a mergeable state (both uncompleted ToDos & merge conflicts), and I can see why Fleckenstein wouldn't want to resume...

> Documentation is missing. > > Also, could you name one or two concrete usecases? (I'm not asking to challenge the legitimacy of this feature, but to judge the API....

> Won't this break a ton of mods that use `get_wielded_item` and `set_wielded_item` in `on_use` callbacks etc.? Perhaps `{get,set}_wielded_item` could vary which inventory it modifies depending on context (i.e. where...