Apoorv Mittal
Apoorv Mittal
@criccomini Seems this has been fixed under https://github.com/wepay/kafka-connect-bigquery/pull/148. @RaiseJohnBarry Can you please confirm, so the issue can be closed.
Doesn't seems to be a duplicate to me rather 2 independent issues. The other issue talks about adding -all identifier but this issue is more about getting the right artifacts.
Ok, will do that. I will post the findings.
> @frankvicky @apoorvmittal10 PTAL when you get a chance, thanks in advance. Thanks for the PR, I am a bot occupied with queues as of now. It's on my list...
> > Thanks for the PR, some minor comments around code. > > Thanks for the review @apoorvmittal10. > > As mentioned, this PR is part of a biggest PR...
Can you please correct the title as per the jira i.e. .....should `not` allow.....
> Thanks for the PR. I had a query, what will happen to the ongoing write state requests to the persister when you close a share partition. I understand that...
@junrao Can I please get review on this.
> @apoorvmittal10 : Thanks for the PR. The code LGTM. Are the test failure related? If not, have they all been tracked? Unrelated tests failure, I have triaged the failures....
> I'm not quite sure about this one. Integrating the leader epoch into the persister write API is good, but I am not sure whether the handling of the fenced...