Adele Okoubo

Results 14 comments of Adele Okoubo

> Without this change, it is possible for one thread to read the size of the TDigest at the same time as it's being updated by the record method. Since...

> One thread does this: > `distRef.get().add(..)` > > Another thread does this: > `distRef.get().size()` > > Having an `AtomicReference `does not prevent `add(..)` from being called at the same...

> I did not measure, and I am not sure how getCount is used - is it used for anything important? Almost every 30 seconds, whenever ffwdReporter reports metrics.

Hey @samfadrigalan , I will handle this since you are tie up on testing.

@malish8632 do we know that limit ?

Well, I wanted more datapoint from teams that are experiencing the problem.I doubt anybody is sending 25MB in the packet. I think the packets drop before reaching UDP max. I...

@lmuhlha Is this problem related to FastForwardReporter or FastForwardHttpReporter ? Is it possible to add the stack trace?

Hello @ClaireMcGinty Agreed it is not easy to test the send method in FastForward. However FastForward is not a final class you can essentially do what you want to do...

> hey @ao2017 ! unfortunately as it is now we can't do that because there's no non-private constructor available in `FastForward` @ClaireMcGinty good point. My comment was based on StubbedFastForwardClient...