anvsky

Results 7 comments of anvsky

> Hi [@anvsk](https://github.com/anvsk), I think [#539](https://github.com/apache/iceberg-go/pull/539) fixes this, could you verify? i try and failed again The new code seems to add a validation/guard only. When the input schema only...

> This test I hacked into `table/transaction_test.go` is also passing: > > func (s *SparkIntegrationTestSuite) TestAddSchemaRegression() { > icebergSchema := iceberg.NewSchema(0, > iceberg.NestedField{ID: 1, Name: "foo", Type: iceberg.PrimitiveTypes.Bool}, > iceberg.NestedField{ID:...

> Not sure I follow - does the server reject the commit? What catalog are you using? rest catalog,the request payload without lastcolumnid

> Which part of your setup is rejecting the request? The client-side rest catalog implementation of iceberg-go? The rest catalog server you are using? > > The last-column-id field as...

> s3tables is returning bad-request when iceberg-go is not sending `last-column-id`? yes,return the error "invalid_metadata: The specified metadata is not valid"

> The error looks like a go error, could you set a breakpoint in `doPost` and get the raw response, e.g. via: > > diff --git a/catalog/rest/rest.go b/catalog/rest/rest.go > index...

> That's strange, the catalog receives only a list of updates & requirements, not sure why it would return `The specified metadata is not valid` instead of rejecting the update,...