Ankur Jain

Results 11 comments of Ankur Jain

Isn't it possible to add a Transcoder interface which has `byte[] asBytes(SerializationModel)` and `SerializationModel fromBytes(byte[])` methods? SerializationModel here being a java object that is good enough to represent any digest....

No. Basically, I wanted to enable **bring your own serialization logic** with some sane ones provided by the lib. By SerializationModel, I am implying **one** java class something on the...

Or DigestModel? I see this as a dto representing digests. Sure, I have some free time next week so expect a PR then.

You mention interchangeability of digest implementations. Presently, MergingDigest and AvlTreeDigest serialize different values so their serialized representation is not equivalent. Will need your inputs on structure of DigestModel and what...

@tdunning Need your inputs on what DigestModel looks like. As mentioned in previous comment, presently different fields are serialized across digest implementations

Apart from bufferSize, MergingDigest serializes `lastUsedCell`. For verbose encoding, this is deserialized and set as a property in digest. For small encoding, lastUsedCell additionally represents the values to read and...

No, PR will take some time. Have paused work on this for few weeks. ________________________________ From: Ted Dunning Sent: Wednesday, August 2, 2017 5:16:10 AM To: tdunning/t-digest Cc: Ankur Jain;...

@tdunning I have raised a PR around this.

@tdunning Did you get a chance to look at the PR?

@tdunning Ping. Is there a timeline for next release? If you don't see this PR #99 making the cut without major changes, let me know.